[PATCH] D128192: [GlobalISel][DebugInfo] Propagate debug location for localized constants

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Localizer.cpp:182
     MI->removeFromParent();
-    MBB.insert(II, MI);
+    auto NewMI = MBB.insert(II, MI);
     Changed = true;
----------------
dzhidzhoev wrote:
> arsenm wrote:
> > Isn't NewMI the same as MI?
> It seems that MI is copied on insert call.
Insert should just insert, the instruction pointer should still be the same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128192/new/

https://reviews.llvm.org/D128192