[PATCH] D129150: [DAG] Canonicalize non-inlane shuffle -> AND if all non-inlane referenced elements are known zero (WIP)

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:22625
+    APInt DemandedRHS = APInt::getNullValue(NumElts);
+    for (int I = 0; I != NumElts; ++I) {
+      int M = Mask[I];
----------------
signed/unsigned comparison.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:22649
+      SmallVector<SDValue, 16> AndMask(NumElts, ZeroElt);
+      for (int I = 0; I != NumElts; ++I)
+        if (Mask[I] == I)
----------------
dito


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129150/new/

https://reviews.llvm.org/D129150