[PATCH] D129282: [AArch64][SVE] Ensure PTEST operands have type nxv16i1

Rosie Sumpter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 05:47:29 PDT 2022


RosieSumpter added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:16178
          "Expected legal scalable vector type!");
 
   // Ensure target specific opcodes are using legal type.
----------------
paulwalker-arm wrote:
> Does adding an assert that `Op->getValueType() == Pg->getValueTypes()` cause any issues, because otherwise I think the `AArch64CC::ANY_ACTIVE` code in unsafe?
Hey Paul, thanks for the comments. I've added the assert - doesn't seem to cause any problems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129282/new/

https://reviews.llvm.org/D129282



More information about the llvm-commits mailing list