[PATCH] D106965: [flang][openacc][NFC] Make self clause value optional in ACC.td and extract the parser

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 05:35:00 PDT 2022


kiranchandramohan added inline comments.


================
Comment at: flang/lib/Lower/OpenACC.cpp:439
+      } else {
+        addSelfAttr = true;
       }
----------------
I guess you mean if it is not a logical expression or an object list it is an empty self clause and should be represented by the selfAttr. If so, I think this is not nested correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106965/new/

https://reviews.llvm.org/D106965



More information about the llvm-commits mailing list