[PATCH] D128101: [DebugInfo][InstrRef] Fix error in copy handling in InstrRefLDV

Fri Jul 8 05:13:25 PDT 2022

StephenTozer added inline comments.

================
Comment at: llvm/test/DebugInfo/X86/instr-ref-track-clobbers.mir:16-17
+## after the move to $r15 or immediately after $rax is clobbered, but no later.
+# CHECK-DAG: DBG_VALUE $r15,
+# CHECK-DAG: $rax = LEA64r
+# CHECK: $rax = MOV64rr
----------------
Orlando wrote:
> Is the unordered-ness of CHECK-DAG limited to anything between the previous and next CHECK lines or not limited at all, do you know?
> 
> Personally I think it would be better to simplify the test to check for the behaviour that occurs now with a comment explaining other permissible behaviour, rather than trying to encode all correct behaviours. wdyt?
I believe the CHECK-DAG lines will still be checked between the previous and next non-DAG directive. I'm personally ambivalent about the "check current behaviour with a comment" vs "check any permissible behaviour" approaches, happy to switch to the former!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128101/new/

https://reviews.llvm.org/D128101