[PATCH] D129004: [Support] Fix Windows dump file hang with multi-threaded crashes
Andrew Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 8 02:32:09 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG86a2f2e2db2a: [Support] Fix Windows dump file hang with multi-threaded crashes (authored by andrewng).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129004/new/
https://reviews.llvm.org/D129004
Files:
llvm/lib/Support/Windows/Signals.inc
Index: llvm/lib/Support/Windows/Signals.inc
===================================================================
--- llvm/lib/Support/Windows/Signals.inc
+++ llvm/lib/Support/Windows/Signals.inc
@@ -731,6 +731,11 @@
/// otherwise.
static std::error_code WINAPI
WriteWindowsDumpFile(PMINIDUMP_EXCEPTION_INFORMATION ExceptionInfo) {
+ struct ScopedCriticalSection {
+ ScopedCriticalSection() { EnterCriticalSection(&CriticalSection); }
+ ~ScopedCriticalSection() { LeaveCriticalSection(&CriticalSection); }
+ } SCS;
+
using namespace llvm;
using namespace llvm::sys;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129004.443176.patch
Type: text/x-patch
Size: 583 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220708/8df2026b/attachment.bin>
More information about the llvm-commits
mailing list