[PATCH] D129336: [llvm-objcopy][ELF] Allow --set-section-flags src=... and --rename-section src=tst

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/set-section-attr-and-rename.test:15
+
+# RUN: not llvm-objcopy --rename-section=.foo=.bar --set-section-flags=.bar=alloc %t %t.2 2>&1 | FileCheck %s --check-prefix=SET-BAR
+
----------------
jhenderson wrote:
> Nit: This line's getting quite long. Perhaps time to split it over two?
> 
> Aside: do we need a similar conflict error for --section-section-alignment?
Probably yes, but the test can be a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129336/new/

https://reviews.llvm.org/D129336