[llvm] 9b37d48 - [UpdateTestChecks] Remove outdated help text

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 00:20:06 PDT 2022


Author: Nikita Popov
Date: 2022-07-08T09:19:16+02:00
New Revision: 9b37d48dd9c26a277c84dd0691173c83616306e2

URL: https://github.com/llvm/llvm-project/commit/9b37d48dd9c26a277c84dd0691173c83616306e2
DIFF: https://github.com/llvm/llvm-project/commit/9b37d48dd9c26a277c84dd0691173c83616306e2.diff

LOG: [UpdateTestChecks] Remove outdated help text

Manually modifying the result of update_test_checks.py is discouraged,
we prefer unmodified check lines where possible. The output is also
considered authoritative nowadays, at least for tests targeting core
middle-end components, where not using it is an automatic review
rejection.

Differential Revision: https://reviews.llvm.org/D129259

Added: 
    

Modified: 
    llvm/utils/update_test_checks.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/update_test_checks.py b/llvm/utils/update_test_checks.py
index dee3a5133f56..c6d8d26f0075 100755
--- a/llvm/utils/update_test_checks.py
+++ b/llvm/utils/update_test_checks.py
@@ -22,11 +22,6 @@
 7. Re-run this script on affected regression tests.
 8. Check the 
diff s to ensure the script has done something reasonable.
 9. Submit a patch including the regression test 
diff s for review.
-
-A common pattern is to have the script insert complete checking of every
-instruction. Then, edit it down to only check the relevant instructions.
-The script is designed to make adding checks to a test case fast, it is *not*
-designed to be authoratitive about what constitutes a good test!
 """
 
 from __future__ import print_function


        


More information about the llvm-commits mailing list