[PATCH] D128982: [LoopVectorize][NFC] Add optional Name parameter to VPInstruction

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 22:16:30 PDT 2022


fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks! I think eventually it would be desirable to keep track of names in a separate table so we don't have to keep those (optional) strings directly in the recipes (similar to LLVM IR value naming), but this seems like a good first step.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:256
   }
+
   case VPInstruction::CanonicalIVIncrement:
----------------
nit: unrelated whitespace change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128982/new/

https://reviews.llvm.org/D128982



More information about the llvm-commits mailing list