[PATCH] D126940: github: Fix release automation /branch command with new repo

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 20:02:05 PDT 2022


tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: llvm/utils/git/github-automation.py:322
+            local_repo = Repo(self.llvm_project_dir)
+            local_repo.git.fetch(f'https://github.com/{owner}/llvm-project', f'{branch}:{branch}')
+            local_repo.git.push(self.push_url, f'{branch}:{branch}', force=True)
----------------
thieta wrote:
> Maybe there should be some error handling here? this block can be retried if fetch or push fails - network errors happens fairly often.
Is there a concise way to do retries in python?  I tried implementing this, but I thought it made the script too complicated.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126940/new/

https://reviews.llvm.org/D126940



More information about the llvm-commits mailing list