[PATCH] D126423: github: Automatically assign reviewers for backport requests

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 17:44:31 PDT 2022


tstellar added inline comments.


================
Comment at: llvm/utils/git/github-automation.py:235
 
+    def issue_request_review(self, commits:List[str]):
+        """
----------------
thieta wrote:
> kwk wrote:
> > When I use capital `L` I get: `NameError: name 'List' is not defined. Did you mean: 'list'?`
> List is a typing hint. You need to import it from the typing module. 
When I use list[str], I get:

TypeError: 'type' object is not subscriptable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126423/new/

https://reviews.llvm.org/D126423



More information about the llvm-commits mailing list