[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Please check both `LLVM_ENABLE_ZSTD={on,off}` work. Ideally, check that when zstd' cmake (`libzstd-dev` on Debian) is unavailable, `LLVM_ENABLE_ZSTD=on` works (there is no zstd functionality but the cmake invocation should succeed).



================
Comment at: llvm/cmake/modules/FindZSTD.cmake:3
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
----------------
MaskRay wrote:
> Search `SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception` from other `.cmake` files
Delete `//`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465