[PATCH] D129326: [scudo] Pass MapPlatformData to all map/unmap calls

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 14:02:46 PDT 2022


cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/primary32.h:518
+  [[no_unique_address]] MapPlatformData StashMapData[MaxStashedRegions] = {};
+  [[no_unique_address]] MapPlatformData RegionsMapData[NumRegions] = {};
 };
----------------
You might want to be careful with an array of `NumRegions` elements as this can become real large real fast.
On Linux for now this isn't a problem as the `MapPlatformData` is empty, and Fuchsia doesn't support the 32-bit primary.
But this is risky in terms of memory footprint.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129326/new/

https://reviews.llvm.org/D129326



More information about the llvm-commits mailing list