[PATCH] D129255: [docs] Move code contribution from GettingStarted.rst to Contributing.rst

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the suggestion. This is mostly a doc move from `Contributing.rst`. The important part is that we agree that the code contribution part from GettingStarted.rst can be moved to Contributing.rst, which I assume we have achieved.
I did not intend to change too much wording and try to keep existing paragraphs. I'll push this shortly as @nickdesaulniers seems have more planned improvement.



================
Comment at: llvm/docs/Contributing.rst:91
 
-
-To get a patch accepted, it has to be reviewed by the LLVM community. This can
-be done using `LLVM's Phabricator`_ or the llvm-commits mailing list.
-Please  follow :ref:`Phabricator#phabricator-reviews <phabricator-reviews>`
-to request a review using Phabricator.
+We don't currently accept GitHub pull requests, and you'll need to send patches
+via :ref:`Phabricator#phabricator-reviews <phabricator-reviews>`.
----------------
nickdesaulniers wrote:
> Consider adding something to denote we also no longer use the mailing list?
> 
> `and the llvm-commits mailing list is deprecated`?
There are quite a few llvm-commits which may need to be reworded after the Discourse migration.
I just add back a sentence to denote what we used to do.



================
Comment at: llvm/docs/Contributing.rst:144
+  # Push to Github.
+  % git push origin HEAD:main
+
----------------
nickdesaulniers wrote:
> Isn't it necessary to merge branch-with-change into main before pushing main?
> 
> i.e. I would do:
> 
> ```
> $ git checkout main
> $ git pull
> $ git rebase --onto main --root branch-with-change
> $ ninja check-$whatever
> $ git checkout main
> $ git merge -
> $ git pull --rebase
> $ git push
> ```
> I guess you're suggesting pushing from the development branch? I guess that should be fine.
Thanks for the suggestion. This is mostly a doc move from `Contributing.rst`. The important part is that we agree that the code contribution part from GettingStarted.rst can be moved to Contributing.rst, which I assume we have achieved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129255/new/

https://reviews.llvm.org/D129255