[PATCH] D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 10:39:35 PDT 2022


jdoerfert added a comment.

In D127399#3636429 <https://reviews.llvm.org/D127399#3636429>, @Meinersbur wrote:

> In D127399#3636310 <https://reviews.llvm.org/D127399#3636310>, @jdoerfert wrote:
>
>> Because that is the clang pattern and we want/need to be compatible.
>
> Clang does not use such a pattern.



  if (!CGF.HaveInsertPoint())                                                                                                                                                                                                                              
     return;

appears 35 times in CGOpenMPRuntime.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127399/new/

https://reviews.llvm.org/D127399



More information about the llvm-commits mailing list