[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 10:36:28 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:27
 
+static constexpr std::string AlgorithmName = "zlib";
 static constexpr int NoCompression = 0;
----------------
Is it still used?

Prefer StringRef if the string is backed from some storage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128953/new/

https://reviews.llvm.org/D128953



More information about the llvm-commits mailing list