[PATCH] D129297: [LSR] Fix bug - check if loop has preheader before calling isInductionPHI

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 10:35:06 PDT 2022


Meinersbur accepted this revision.
Meinersbur added a subscriber: nathanchance.
Meinersbur added a comment.
This revision is now accepted and ready to land.

In the interest to not block @nathanchance with a crashing compiler, I suggest to commit as soon as possible. However, a complete patch would also include a regression test.



================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1249
 
+bool checkIsIndPhi(PHINode *Phi, Loop *L, ScalarEvolution *SE,
+                   InductionDescriptor &ID) {
----------------
Please add a doxygen comment briefly describing what this is checking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129297/new/

https://reviews.llvm.org/D129297



More information about the llvm-commits mailing list