[PATCH] D128408: [LV] Remove collectTriviallyDeadInstructions, already handled by VP DCE.

Thu Jul 7 08:38:08 PDT 2022

fhahn marked 2 inline comments as done.
fhahn added inline comments.

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8545
   // control flow is preserved, we should keep them.
+  SmallPtrSet<Instruction *, 4> DeadInstructions;
   auto &ConditionalAssumes = Legal->getConditionalAssumes();
----------------
Ayal wrote:
> Shall assumes be dropped as a VPlan2VPlan transformation, thereby eliminating DeadInstructions, simplifying sinking after them below, and potentially taking care of the TODO? As separate follow-up patch(es).
> As separate follow-up patch(es).

Yes I am planning on doing this as follow up, the goal is to completely remove `DeadInstructions`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128408/new/

https://reviews.llvm.org/D128408