[PATCH] D128101: [DebugInfo][InstrRef] Fix error in copy handling in InstrRefLDV

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1777
   if (TTracker && isCalleeSavedReg(DestReg) && SrcRegOp->isKill())
     TTracker->transferMlocs(MTracker->getRegMLoc(SrcReg),
                             MTracker->getRegMLoc(DestReg), MI.getIterator());
----------------
Is it significant that the "The copy might have clobbered variables based on the destination register" loop has moved above up above this part? 


================
Comment at: llvm/test/DebugInfo/X86/instr-ref-track-clobbers.mir:16-17
+## after the move to $r15 or immediately after $rax is clobbered, but no later.
+# CHECK-DAG: DBG_VALUE $r15,
+# CHECK-DAG: $rax = LEA64r
+# CHECK: $rax = MOV64rr
----------------
Is the unordered-ness of CHECK-DAG limited to anything between the previous and next CHECK lines or not limited at all, do you know?

Personally I think it would be better to simplify the test to check for the behaviour that occurs now with a comment explaining other permissible behaviour, rather than trying to encode all correct behaviours. wdyt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128101/new/

https://reviews.llvm.org/D128101