[PATCH] D129141: [ARM] Switch the costs of mve1beat and mve4beat

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 07:05:44 PDT 2022


samtebbs accepted this revision.
samtebbs added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/LoopVectorize/ARM/pointer_iv.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -loop-vectorize -S -mtriple=thumbv8.1m.main-none-none-eabi -mattr=+mve.fp,mve1beat -dce -instcombine --simplifycfg -simplifycfg-require-and-preserve-domtree=1 -tail-predication=disabled < %s | FileCheck %s
+; RUN: opt -loop-vectorize -S -mtriple=thumbv8.1m.main-none-none-eabi -mattr=+mve.fp,mve4beat -dce -instcombine --simplifycfg -simplifycfg-require-and-preserve-domtree=1 -tail-predication=disabled < %s | FileCheck %s
 
----------------
dmgreen wrote:
> samtebbs wrote:
> > Is this required, considering it doesn't change the rest of the test?
> It is needed to keep the test checking the same thing. It requires that the MVE instructions have a cost of 1 for the same vectorization to happen.
That makes sense, cheers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129141/new/

https://reviews.llvm.org/D129141



More information about the llvm-commits mailing list