[llvm] 8d9dc83 - X86: add newline to end of FMA instruction comments.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 04:35:33 PDT 2022


Author: Tim Northover
Date: 2022-07-07T12:35:28+01:00
New Revision: 8d9dc83f35a3c5ec40b97072a8a856e8fefe446c

URL: https://github.com/llvm/llvm-project/commit/8d9dc83f35a3c5ec40b97072a8a856e8fefe446c
DIFF: https://github.com/llvm/llvm-project/commit/8d9dc83f35a3c5ec40b97072a8a856e8fefe446c.diff

LOG: X86: add newline to end of FMA instruction comments.

The newline is used by Disassembler.cpp (`emitComments`) to work out how to
format them properly, and if there's no newline it goes into an infinite loop.

Unfortunately I couldn't get llvm-objdump to be affected, only the MacOS otool
utility which dlopens libLTO.

Added: 
    

Modified: 
    llvm/lib/Target/X86/MCTargetDesc/X86InstComments.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86InstComments.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86InstComments.cpp
index a903c5f455a2e..da90befb23209 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86InstComments.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86InstComments.cpp
@@ -622,7 +622,7 @@ static bool printFMAComments(const MCInst *MI, raw_ostream &OS,
     OS << '-';
 
   OS << '(' << Mul1Name << " * " << Mul2Name << ") " << AccStr << ' '
-     << AccName;
+     << AccName << '\n';
 
   return true;
 }


        


More information about the llvm-commits mailing list