[PATCH] D127383: Don't treat readnone call in presplit coroutine as not access memory

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 01:37:14 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Analysis/GlobalsModRef.cpp:270
+            // Since a coroutine might resume in different threads.
+            !Call->getFunction()->isPresplitCoroutine())
           Min = FMRB_DoesNotAccessMemory;
----------------
I've taken the liberty of deleting this whole function in https://github.com/llvm/llvm-project/commit/4a579abd9f95bf9fda920759aced3874d04c5b9e. This was unnecessary code duplication with BasicAA.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127383/new/

https://reviews.llvm.org/D127383



More information about the llvm-commits mailing list