[PATCH] D129028: [SelectionDAG] computeKnownBits / ComputeNumSignBits for the remaining overflow-aware nodes

Thu Jul 7 01:17:55 PDT 2022

foad added a comment.

In D129028#3630395 <https://reviews.llvm.org/D129028#3630395>, @barannikov88 wrote:

> This is my first patch. I would really appreciate it if someone could guide me through the process of contribution.
> What do I do next once the patch is approved by the reviewers (e.g. is there a way I can merge it myself or will it be merged automatically / by some other person)?

For your first few patches you can ask someone else to do it. Then you should apply for commit access.

> How many approvals do I need?

Usually one approval is enough, unless some other reviewer is still unhappy with the patch.

> Is there some kind of CODEOWNERS whose approve is mandatory?

No. There is an llvm CODE_OWNERS.TXT but the people listed there are supposed to be responsible for ensuring that patches to a particular part of the compiler get reviewed. They are not mandatory reviewers for every single patch themselves.

> I have read https://llvm.org/docs/Contributing.html but it does not answer all questions, so any additional information would be helpful.

There are also other docs linked from https://llvm.org/docs/GettingInvolved.html like the Developer Policy and the Code-Review Policy.

In D129028#3630627 <https://reviews.llvm.org/D129028#3630627>, @barannikov88 wrote:

> It seems I don't have permission to land the patch. Could someone do this please?

Yes I can do it. What is your preferred name and email address for the Author: header? (Or do you have an existing github account with some commits I can copy it from?)

> I also see a build bot failure, but the error seems unrelated:
> https://buildkite.com/llvm-project/premerge-checks/builds/101001#0181cec4-b429-490e-8703-f179f25541b2/6-12053
>
>   Failed Tests (1):
>     BOLT :: runtime/X86/user-func-reorder.c
>
> Is it OK or should I look into it?

If you're reasonably sure it's unrelated then I guess it's OK to ignore it. I'm not even sure how to run the BOLT tests. I don't think they are part of check-llvm.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129028/new/

https://reviews.llvm.org/D129028