[PATCH] D129259: [UpdateTestChecks] Remove outdated help text

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 00:59:01 PDT 2022


nikic created this revision.
nikic added reviewers: spatel, RKSimon.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Manually modifying the result of update_test_checks.py is discouraged, we prefer unmodified check lines where possible. The output is also considered authoritative nowadays, at least for tests targeting core middle-end components, where not using it is an automatic review rejection.


https://reviews.llvm.org/D129259

Files:
  llvm/utils/update_test_checks.py


Index: llvm/utils/update_test_checks.py
===================================================================
--- llvm/utils/update_test_checks.py
+++ llvm/utils/update_test_checks.py
@@ -22,11 +22,6 @@
 7. Re-run this script on affected regression tests.
 8. Check the diffs to ensure the script has done something reasonable.
 9. Submit a patch including the regression test diffs for review.
-
-A common pattern is to have the script insert complete checking of every
-instruction. Then, edit it down to only check the relevant instructions.
-The script is designed to make adding checks to a test case fast, it is *not*
-designed to be authoratitive about what constitutes a good test!
 """
 
 from __future__ import print_function


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129259.442810.patch
Type: text/x-patch
Size: 734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220707/ac72d5ae/attachment.bin>


More information about the llvm-commits mailing list