[PATCH] D129256: [BasicBlockUtils] Allow critical edge splitting with callbr terminators

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: nickdesaulniers, nathanchance, efriedma, craig.topper.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

After D129205 <https://reviews.llvm.org/D129205>, we support SplitBlockPredecessors() for predecessors with callbr terminators. This means that it is now also safe to invoke critical edge splitting for an edge coming from a callbr terminator. Remove checks in various passes that were protecting against that.


https://reviews.llvm.org/D129256

Files:
  llvm/lib/Transforms/Scalar/GVN.cpp
  llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
  llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp
  llvm/test/Transforms/GVN/callbr-loadpre-critedge.ll
  llvm/test/Transforms/GVN/callbr-scalarpre-critedge.ll
  llvm/test/Transforms/LoopStrengthReduce/callbr-critical-edge-splitting.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129256.442806.patch
Type: text/x-patch
Size: 9105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220707/b8c12c07/attachment.bin>