[PATCH] D129230: [IR][coroutine] make final and non-final llvm.coro.saves unique

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D129230#3634730 <https://reviews.llvm.org/D129230#3634730>, @nikic wrote:

> Another possibility is to mark llvm.coro.save as IntrNoMerge, though that would prevent any merging (similar to the SimplifyCFG patch, just only for this intrinsic and not other token-returning intrinsics).
>
> I'm not familiar with these coro intrinsics, but if these have two different ways of being lowered, then adding a flag to distinguish them generally makes sense to me.

Ah, `nomerge` function attribute looks very useful. Although it could not cover all the cases perfectly, I wouldn't be too worried since these cases should be relatively rare in practice.

@ChuanqiXu @nikic Thanks for the discussion. I'll create a patch to obsolete D129025 <https://reviews.llvm.org/D129025>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129230/new/

https://reviews.llvm.org/D129230