[PATCH] D129232: [llvm][docs] add another patch for `arc patch` fix

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers created this revision.
nickdesaulniers added reviewers: MaskRay, tstellar, BertalanD, cjdb, jyknight.
Herald added a subscriber: StephenFan.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix PHP 8.1 incompatibility with `arc patch D<12345>`

Fixes the following observed error with PHP 8.1:

  EXCEPTION: (RuntimeException) preg_match(): Passing null to parameter phacility#2 ($subject) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  arcanist(head=master, ref.master=acec17af414f)
    #0 PhutilErrorHandler::handleError(integer, string, string, integer)
    phacility#1 preg_match(string, NULL, NULL) called at [<arcanist>/src/repository/api/ArcanistGitAPI.php:603]
    phacility#2 ArcanistGitAPI::getCanonicalRevisionName(NULL) called at [<arcanist>/src/repository/api/ArcanistGitAPI.php:1146]
    phacility#3 ArcanistGitAPI::hasLocalCommit(NULL) called at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:433]
    phacility#4 ArcanistPatchWorkflow::run() called at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:398]
    phacility#5 ArcanistPatchWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]

Link: https://secure.phabricator.com/book/phabcontrib/article/contributing_code/
Signed-off-by: Nick Desaulniers <ndesaulniers at google.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129232

Files:
  llvm/docs/GettingStarted.rst


Index: llvm/docs/GettingStarted.rst
===================================================================
--- llvm/docs/GettingStarted.rst
+++ llvm/docs/GettingStarted.rst
@@ -478,6 +478,8 @@
   % cd arcanist
   % git fetch https://github.com/rashkov/arcanist update_cacerts
   % git cherry-pick e3659d43d8911e91739f3b0c5935598bceb859aa
+  % git fetch https://github.com/nickdesaulniers/arcanist/ php_8_1
+  % git cherry-pick 1e2f4b15a87659a17bad5abcdbf73fbc7a02fab8
 
 Once this is all done, you can upload the latest commit using:
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129232.442697.patch
Type: text/x-patch
Size: 533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220706/89443df2/attachment.bin>