[PATCH] D128082: [BOLT][AArch64] Handle gold linker veneers

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 13:54:02 PDT 2022


yota9 added inline comments.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:2889
       Function.setIgnored();
       continue;
     }
----------------
rafauler wrote:
> Notice this "continue" here. It will cause us to skip calling "BC->processInterproceduralReferences(Function)" for an ignored function.
I'm starting to see now, thanks! Probably your CI uses processAllFunctions flag? What if I will re-open the review and will add isIgnored() check in BCs processInterproceduralReferences()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128082/new/

https://reviews.llvm.org/D128082



More information about the llvm-commits mailing list