[PATCH] D128082: [BOLT][AArch64] Handle gold linker veneers

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 13:19:08 PDT 2022


rafauler added a comment.

The cause of the crash caused by this diff is because this diff moves processing of interprocedural references outside the disassembly loop.

In the disassembly loop, we don't call "process interprocedural references" on every function. For non simple functions, we bail out early.

With this diff, we process all interprocedural references, even the ones coming from non-simple/ignored functions. We happen to have an internal binary with a non-simple function that has a very weird interprocedural reference that, when processed, causes BOLT to crash  (it's an invalid address that can't be mapped to any function).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128082/new/

https://reviews.llvm.org/D128082



More information about the llvm-commits mailing list