[PATCH] D129205: [BasicBlockUtils] Allow splitting predecessors with callbr terminators

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D129205#3633528 <https://reviews.llvm.org/D129205#3633528>, @efriedma wrote:

> If we don't support using arbitrary blockaddresses as destinations, can we stop using blockaddress to represent the destinations?  The presence of blockaddress blocks optimizations even if we aren't imposing the full control flow restrictions.

Yeah, dropping the blockaddress arguments sounds reasonable and should largely remove the need for special handling of callbr in transforms. I think a possible way to do this would be to say that we implicitly pass the blockaddresses for all callbr targets at the end of the argument list. (Not sure I want to volunteer for that change though...)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129205/new/

https://reviews.llvm.org/D129205