[PATCH] D127037: [OpenMP][IRBuilder] 'omp target enter data' support.

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

AFAICT this patch does not do what its title and description say (`'omp target enter data' support`). Can you update it to reflect what is actually done?



================
Comment at: mlir/lib/Target/LLVMIR/Dialect/Utils/CommonOpenMPOpenACCUtils.cpp:1
-//===- OpenACCToLLVMIRTranslation.cpp -------------------------------------===//
+//===- CommonOpenMPOpenACC.cpp - Utilities used by OpenMP and OpenACC -----===//
 //
----------------
Not a big fan of the name of this file. I think `ToLLVMIRTranslation` should be part of it. 

maybe `DiretiveToLLVMIRTranslation`


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/Utils/CommonOpenMPOpenACCUtils.cpp:79
 }
+//===----------------------------------------------------------------------===//
+// Utility functions
----------------
The functions above are also utilities so I'm not sure this is really needed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127037/new/

https://reviews.llvm.org/D127037