[PATCH] D127994: [AMDGPU] Expose CLI controls for IGroup ordering

Jeffrey Byrnes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 11:03:22 PDT 2022


jrbyrnes updated this revision to Diff 442638.
jrbyrnes marked 7 inline comments as done.
jrbyrnes added a comment.

Addressed review comments.

Refactor implementation to change the product of parsing. The parser now generates a {SchedGroupMask, Optional<unsigned>} pair to represent the IGroup and MaxSize, which is directly used to construct SchedGroups in the mutation.

Mainly enabled by removal of canAddMIFn in favor of a common canAddMI for the SchedGroup class. Due to this, it is no longer necessary to map command line strings to canAddMIs. Additionally, handleGroup harcodes a map between Groups -> SubGroups (note: handleGroup will be removed in next iteration, as multiple groups of same type will be allowed). These two things allowed for removal of IGroupTable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127994/new/

https://reviews.llvm.org/D127994

Files:
  llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
  llvm/test/CodeGen/AMDGPU/igrouplp-dag-mutation.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127994.442638.patch
Type: text/x-patch
Size: 52813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220706/4c4c1c94/attachment.bin>


More information about the llvm-commits mailing list