[PATCH] D129001: [PGO] Report number of counts being dropped when a hash-mismatch happens.

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 10:18:27 PDT 2022


It's almost impossible for the sum of a function's raw count values to
reach the max of uint64. If that happens, there must be something wrong.
We handle saturation in BFI weight where the type is int32.

-Rong

On Wed, Jul 6, 2022 at 9:48 AM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:1043
> +        continue;
> +      ValueSum += CountValue;
> +    }
> ----------------
> Add handling of saturation using max.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D129001/new/
>
> https://reviews.llvm.org/D129001
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220706/a97e7d26/attachment.html>


More information about the llvm-commits mailing list