[PATCH] D129205: [BasicBlockUtils] Allow splitting predecessors with callbr terminators

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1510-1512
   for (BasicBlock *BBPred : predecessors(BB)) {
-    if (isa<IndirectBrInst>(BBPred->getTerminator()) ||
-        isa<CallBrInst>(BBPred->getTerminator()))
----------------
nickdesaulniers wrote:
> I think I attempted this in https://reviews.llvm.org/D94833, see the attached bug report from @nathanchance .
I think that patch was missing the change to SplitBlockPredecessors() done here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129205/new/

https://reviews.llvm.org/D129205