[PATCH] D126423: github: Automatically assign reviewers for backport requests

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk requested changes to this revision.
kwk added a comment.
This revision now requires changes to proceed.

Can you please add links to the phabricator HTTP API documentation that you're using?



================
Comment at: llvm/utils/git/github-automation.py:77
+
+def phab_login_to_github_login(phab_token:str, repo:github.Repository.Repository, phab_login:str) -> str:
+    args = {
----------------



================
Comment at: llvm/utils/git/github-automation.py:235
 
+    def issue_request_review(self, commits:List[str]):
+        """
----------------
When I use capital `L` I get: `NameError: name 'List' is not defined. Did you mean: 'list'?`


================
Comment at: llvm/utils/git/github-automation.py:257
+        self.issue.create_comment(message)
+        self.issue.add_to_assignees(*reviewers)
+
----------------
What if the list of reviewers is empty? Don't you want to skip that call to `add_to_assignees`?


================
Comment at: llvm/utils/git/github-automation.py:276
+        except Exception as e:
+            print("error: Failed while searching for reviewers", e)
+
----------------
Do you still want to continue when the exception was caught?


================
Comment at: llvm/utils/git/github-automation.py:503
 release_workflow_parser.add_argument('--issue-number', type=int, required=True, help='The issue number to update')
+release_workflow_parser.add_argument('--phab-token', type=str, help='Phabricator conduit API token')
 release_workflow_parser.add_argument('--branch-repo-token', type=str,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126423/new/

https://reviews.llvm.org/D126423