[PATCH] D125744: github: Add a helpful message for issues without milestones

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk requested changes to this revision.
kwk added a comment.
This revision now requires changes to proceed.

Looks good except for what I think is a typo and some suggestion for improving the readability and how things are connected with the workflow. Afterall, this is triggered by a comment, that produces another comment that we want to ignore or skip. Hm, maybe skip is better than ignore?



================
Comment at: llvm/utils/git/github-automation.py:153-155
+    def issue_notify_no_milestone(self, comment) -> None:
+        message = "<!--IGNORE-->\n>{}\n\nError: Command failed due to missing milestone.".format(comment)
+        self.issue.create_comment(message)
----------------
`<!--IGNORE-->` seems like a special comment that gets parsed here: https://github.com/llvm/llvm-project/blob/7e5f75aa37801b9e4e9f0e3fb9f0358cbafb6f63/.github/workflows/issue-release-workflow.yml#L35. I suggest to create a dedicated function for this to make this more obvious where this gets ignored. Also I think the `>` before the `{}` placeholder was not intended, right?


================
Comment at: llvm/utils/git/github-automation.py:164
     def issue_notify_cherry_pick_failure(self, commit:str) -> github.IssueComment.IssueComment:
         message = "<!--IGNORE-->\nFailed to cherry-pick: {}\n\n".format(commit)
         action_url = self.action_url
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125744/new/

https://reviews.llvm.org/D125744