[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

[Prabhdeep Soni via Phabricator via llvm-commits]

psoni2628 added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:608
+  ///
+  /// \param DL      Debug location for instructions added by unrolling.
+  /// \param Loop    The simd loop.
----------------
jdoerfert wrote:
> No debug location needed. You also copied the comment that makes little sene.
It isn't used in the original applySimd either. Should I remove it in both places?


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2885
+void OpenMPIRBuilder::applySimdlen(DebugLoc, CanonicalLoopInfo *CanonicalLoop,
+                                   llvm::ConstantInt *Simdlen) {
+  LLVMContext &Ctx = Builder.getContext();
----------------
psoni2628 wrote:
> jdoerfert wrote:
> > Also above, no llvm::
> It isn't used in the original `applySimd` either. Should I remove it in both places?
Wrong comment to reply to. Please ignore this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129149/new/

https://reviews.llvm.org/D129149