[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 07:57:21 PDT 2022


kiranchandramohan added a comment.

Nit: Also add to the summary that this patch uses the simdlen support in OpenMPIRBuilder when it is enabled in Clang.



================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600
+      continue;
+    else
+      return false;
----------------
Nit: Else after return/continue is discouraged.
https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129149/new/

https://reviews.llvm.org/D129149



More information about the llvm-commits mailing list