[PATCH] D128241: [AMDGPU] Use AddedComplexity for ret and noret atomic ops selection

Abinav Puthan Purayil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 06:59:28 PDT 2022


abinavpp added a comment.

In D128241#3630653 <https://reviews.llvm.org/D128241#3630653>, @arsenm wrote:

> Did the default complexity calculation account for the additional no use predicate in the opposite direction of what we want?

I don't think I understood the question. I set the AddedComplexity in such a way that no-return matches are always done first since we're only adding predicates for those. By "default complexity", are we talking about getting PatternToMatch::getPatternComplexity() in CodeGenDagPatterns to give higher complexity to patterns with HasNoUse predicates?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128241/new/

https://reviews.llvm.org/D128241



More information about the llvm-commits mailing list