[PATCH] D129109: [Costmodel] Add type based costmodel analysis for masked scatter/gather intrinsics

[Malhar via Phabricator via llvm-commits]

malharJ added inline comments.


================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:62
+    Intrinsic::ID Id, const CallBase &CI, InstructionCost ScalarizationCost,
+    bool TypeBasedOnly)
     : II(dyn_cast<IntrinsicInst>(&CI)), RetTy(CI.getType()), IID(Id),
----------------
mgabka wrote:
> would it be beneficial to keep the TypeBasedOnly as a property of IntrinsicCostAttributes ?
I think given that there is only one usage right now, ie. in the constructor below,
perhaps it's not worth making into a member variable ?





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129109/new/

https://reviews.llvm.org/D129109