[PATCH] D129066: [AArch64][CodeGen] Add AArch64 support for complex deinterleaving

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:21413
+bool AArch64TargetLowering::isComplexDeinterleavingSupported() const {
+  return Subtarget->hasComplxNum() && Subtarget->hasNEON();
+}
----------------
I think ComplxNum requires NEON, so checking for the first should be enough.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:21460
+
+    dbgs() << "IntId: " << IntId << ", Name: " << IdNames[IntIdx] << ".\n";
+    dbgs() << "Type: ";
----------------
There is quite a lot of debug message left here. I assume it will be removed in the final version?


================
Comment at: llvm/test/CodeGen/AArch64/ComplexArithmetic/complex-arithmetic-f16-add.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s --mattr=+complxnum,+neon,+fullfp16 -o - | FileCheck %s
----------------
These don't need to be in a "ComplexArithmetic" directory - they are already easy to identify from the file prefix.


================
Comment at: llvm/test/CodeGen/AArch64/ComplexArithmetic/complex-arithmetic-f16-add.ll:6
+
+
+
----------------
Can you try and clean up these newlines too. There are gaps in places, but some of the functions are a little jammed together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129066/new/

https://reviews.llvm.org/D129066