[PATCH] D129109: [Costmodel] Add type based costmodel analysis for masked scatter/gather intrinsics

[mgabka via Phabricator via llvm-commits]

mgabka added a comment.

I think it would be good to explain in the commit message that this patch allows to print cost calculated only based on argument types and that it is useful feature to have for testing purposes.



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:133
+      InstructionCost ScalarCost = InstructionCost::getInvalid(),
+      bool TypeBasedOnly=false);
 
----------------
incorrect formatting


================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:62
+    Intrinsic::ID Id, const CallBase &CI, InstructionCost ScalarizationCost,
+    bool TypeBasedOnly)
     : II(dyn_cast<IntrinsicInst>(&CI)), RetTy(CI.getType()), IID(Id),
----------------
would it be beneficial to keep the TypeBasedOnly as a property of IntrinsicCostAttributes ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129109/new/

https://reviews.llvm.org/D129109