[PATCH] D128890: [InstCombine] remove useless insertelement

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 01:06:31 PDT 2022


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - but please add back the FIXME that you're lost in the rebase



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:248
+      // extractelement (bitcast (Vec), a)
+      if (X->hasOneUse() && Ext.getVectorOperand()->hasOneUse()) {
+        Value *NewBC = Builder.CreateBitCast(Vec, Ext.getVectorOperandType());
----------------
Add back the FIXME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128890/new/

https://reviews.llvm.org/D128890



More information about the llvm-commits mailing list