[PATCH] D129142: [LLD][ELF] Drop duplicates from rpath

[Stephan Bergmann via Phabricator via llvm-commits]

sberg marked 2 inline comments as done.
sberg added a comment.

In D129142#3631023 <https://reviews.llvm.org/D129142#3631023>, @MaskRay wrote:

> Does this change the behavior in any way?

Yes, the non-degenerate test case changes from

  Library runpath: [/path1:/path12:/path2:/path2:/path1]

to

  Library runpath: [/path1:/path12:/path2]



================
Comment at: lld/test/ELF/rpath.test:3
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+// RUN: ld.lld %t.o -rpath=/path1 -rpath=/path12 -rpath=/path2 -rpath=/path2 -rpath=/path1 -shared -o %t
+// RUN: llvm-readobj --dynamic-table %t | FileCheck %s
----------------
MaskRay wrote:
> You may change some `-rpath` to `-rpath `
> 
You mean, add some variance `-rpath=...` vs. `-rpath ...`?  But IMO that would just distract from what gets tested here.  So I rather updated the test file (and its name) to make it more clear what it is actually testing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129142/new/

https://reviews.llvm.org/D129142