[PATCH] D128876: [RISCV] Fix wrong register rename for store value during make-compressible optimization

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng marked an inline comment as done.
kito-cheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMakeCompressible.cpp:105
+  // Indicate there is no compressible chance.
+  bool Incompressible() const {
+    return Reg == RISCV::NoRegister && Offset == 0;
----------------
craig.topper wrote:
> Methods name start with lower case. 
> 
> Is this ever called?
Use `CI.incompressible()` instead of `!RegImm.Reg && RegImm.Imm == 0` now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128876/new/

https://reviews.llvm.org/D128876