[PATCH] D128982: [LoopVectorize][NFC] Add optional Name parameter to VPInstruction

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:769
+  /// An optional name that can be used for the generated IR instruction.
+  const Twine Name;
+
----------------
Is `Twine` something typically used as a storage type?  Most instances seem to be for parameter passing.  Which makes me wonder if the storage type should be `std::string`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128982/new/

https://reviews.llvm.org/D128982