[PATCH] D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 15:25:53 PDT 2022


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM. Thank you again! :)



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:321
+    case ELFTLSDescCall: {
+      SkipCreateEdge = true;
+      break;
----------------
Can we just return `Error::success();` here, rather than setting a skip variable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128601/new/

https://reviews.llvm.org/D128601



More information about the llvm-commits mailing list