[PATCH] D127637: [MC][MachO] Change addrsig format + ensure its size is properly set

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 14:17:58 PDT 2022


int3 added inline comments.


================
Comment at: llvm/lib/MC/MCMachOStreamer.cpp:609
+  // actually be applied by the linker.
+  Frag->getContents().resize(8);
 }
----------------
could use the actual machine pointer size here, but I'm not sure how to check for 64/32 bit elegantly here. `MCMachObjectTargetWriter::is64Bit()` exists, but that would require downcasting `writer` here which seems kinda ugly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127637/new/

https://reviews.llvm.org/D127637



More information about the llvm-commits mailing list