[PATCH] D129084: [AMDGPU] gfx11 Fix disassembler for VOP3 dpp8

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 13:18:45 PDT 2022


Petar.Avramovic added a comment.

> op_sel value is not being propagated from src_modifiers to the op_sel operand

I was convinced that op_sel value is not important for instruction printing. Non dpp version does not even have op_sel operand and still gets printed correctly, helper prints op_sel[a,b,c] from src_modifiers.
I missed to test assembler, missing part is setting op_sel bit in src_modifiers, done via cvtVOP3P.
I will double check both.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129084/new/

https://reviews.llvm.org/D129084



More information about the llvm-commits mailing list