[PATCH] D129148: [ConstExpr] Remove div/rem constant expressions

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.

Not required, but I'd encourage you to avoid deleting the tests.  I spot checked and didn't see any where removing wasn't at least defensible, but I'd generally prefer to see the constant exprs replaces with instructions and the tests kept as much as possible.  I worry that tests which appear to exercise only trapping constants might be the only trapping coverage we have at all for a given transform.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129148/new/

https://reviews.llvm.org/D129148